chore(docs): Fix some typos in specs of private kernel initial #6224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanmon
commented
May 6, 2024
| @@ -168,8 +168,8 @@ The circuit undergoes the following validations for data within [`private_inputs | |||
| For each `note_hash` at index `i` in `note_hashes`: | |||
|
|
|||
| - Find the `request_index` at [`hints`](#hints).`note_hash_range_hints[i]`, which is the index of the `private_call_requests` with the smallest `counter_start` that was emitted after the `note_hash`. | |||
| - If `request_index` equals `NM`, indicating no request was emitted after the `note_hash`, its counter must be greater the `counter_end` of the last request. | |||
| - If `request_index` equals `0`, indicating no request was emitted before the `note_hash`. Its counter must be less the `counter_start` of the first request. | |||
| - If `request_index` equals `NE`, indicating no request was emitted after the `note_hash`, its counter must be greater than the `counter_end` of the last request. | |||
There was a problem hiding this comment.
@LeilaWang I replaced 'NM' by 'NE' as NM is not defined in the document.
Docs PreviewHey there! 👋 You can check your preview at https://663a5ccc8680e928a30bc175--aztec-docs-dev.netlify.app |
jeanmon
force-pushed
the
jm/typos-docs-private-kernel-init
branch
2 times, most recently
from
34653e7 to
e1aee09
Compare
LeilaWang
approved these changes
May 7, 2024
jeanmon
force-pushed
the
jm/typos-docs-private-kernel-init
branch
from
e1aee09 to
474f19d
Compare
Changes to circuit sizes
🧾 Summary (100% most significant diffs)
Full diff report 👇
|
This was referenced May 7, 2024
TomAFrench
added a commit
that referenced
this pull request
May 8, 2024
* master: (25 commits) fix: Enable client proof tests (#6249) chore: update cspell for abi demonomorphizer (#6258) feat(aztec-nr): add 'with_gas()' function to avm call interface (#6256) git subrepo push --branch=master noir-projects/aztec-nr git_subrepo.sh: Fix parent in .gitrepo file. [skip ci] chore: replace relative paths to noir-protocol-circuits git subrepo push --branch=master barretenberg fix: Pw/update merge check (#6201) chore(master): Release 0.37.1 (#6148) fix: Cl/split out e2e tests (#6242) feat: Typings generator with generics (#6235) chore(ci): fix restarts with fresh spot, acir test fixes, non-mandatory benches (#6226) chore: misc AVM migration prep changes (#6253) feat!: AES blackbox (#6016) chore(docs): Fix some typos in specs of private kernel initial (#6224) chore(aztec-macros): avm function return types are auto tagged as `pub` (#6250) chore(aztec-nr): create a 'with_selector' version of `emit_unencrypted_log` in avm context (#6248) fix: registering PublicDataWitness in JsonRpcServer (#6243) feat: Sync from noir (#6234) feat(avm-simulator): consider previous pending nullifiers across enqueued calls (#6188) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.