feat: Separate aggregation protocol #2736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ledwards2225
changed the title
ledwards2225
force-pushed
the
lde/aggregation_protocol
branch
from
7cf2ebf to
492fee9
Compare
Rumata888
reviewed
Oct 10, 2023
| auto honk_verified = construct_and_verify_honk_proof(composer, builder); | ||
| EXPECT_TRUE(honk_verified); | ||
|
|
||
| // Construct and verify Goblin ECC op queue Merge its proof |
There was a problem hiding this comment.
Did you want to write "Merge its proof"?
There was a problem hiding this comment.
Corrected, thanks
Rumata888
approved these changes
Oct 10, 2023
ledwards2225
force-pushed
the
lde/aggregation_protocol
branch
from
492fee9 to
3857a65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the Goblin ECC op queue transcript aggregation protocol from the main Honk protocol to its own separate mini-protocol, referred to as "Merge" (based on Zac's original Goblin doc). Zac pointed out that this was likely the right approach once we go to incorporate folding.
This is also a necessary step for completing integration of ZeroMorph (and deprecation of Gemini/Shplonk) because the univariate evaluation claims related to this merge protocol would have otherwise needed to be incorporated via Shplonk.
This work automatically resolves one of the issues previously described in bberg 723 related to the size of the transcript polynomials being tied to the size of the present circuit.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.