Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup phases in avm witgen #10432

Conversation

dbanks12
Copy link
Collaborator

@dbanks12 dbanks12 commented Dec 5, 2024

No description provided.

@dbanks12 dbanks12 changed the title chore: cleanup phases in avm witgen chore: cleanup phases in avm witgen [WIP] Dec 5, 2024
@dbanks12 dbanks12 added e2e-all CI: Enables this CI job. e2e-prover-full CI: Enables this CI job. labels Dec 5, 2024
@dbanks12 dbanks12 changed the title chore: cleanup phases in avm witgen [WIP] chore: cleanup phases in avm witgen Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

Changes to public function bytecode sizes

Generated at commit: 0667eb45b033a76c3bb7c225d786114fb14f9cf2, compared to commit: 17d49622ad39abf708af34c811323177c262b133

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch -4 ✅ -0.01%
AvmTest::n_storage_writes -4 ✅ -0.22%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
AvmTest::public_dispatch 62,560 (-4) -0.01%
AvmTest::n_storage_writes 1,800 (-4) -0.22%

Copy link
Contributor

github-actions bot commented Dec 5, 2024

Changes to circuit sizes

Generated at commit: 0667eb45b033a76c3bb7c225d786114fb14f9cf2, compared to commit: 30dda53520a0b08627b1c65c783140c8dcd2cf23

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public +268,654 ❌ +59.36% +20,667,146 ❌ +414.75%
private_kernel_init +56 ❌ +0.21% +54 ❌ +0.14%
private_kernel_inner +63 ❌ +0.14% +61 ❌ +0.10%
rollup_base_private +506 ❌ +0.23% +379 ❌ +0.01%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_public 721,202 (+268,654) +59.36% 25,650,146 (+20,667,146) +414.75%
private_kernel_init 26,397 (+56) +0.21% 38,197 (+54) +0.14%
private_kernel_inner 44,664 (+63) +0.14% 62,034 (+61) +0.10%
rollup_base_private 220,672 (+506) +0.23% 3,598,501 (+379) +0.01%

@dbanks12 dbanks12 merged commit bd64cc5 into ir/11-28-feat_enqueued_call_side_effect_trace Dec 5, 2024
104 checks passed
@dbanks12 dbanks12 deleted the db/cleanup-phases-witgen branch December 5, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e-all CI: Enables this CI job. e2e-prover-full CI: Enables this CI job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant