Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort props in noir contract artifact when loading #6021

Closed
sklppy88 opened this issue Apr 25, 2024 · 0 comments · Fixed by #9772
Closed

Sort props in noir contract artifact when loading #6021

sklppy88 opened this issue Apr 25, 2024 · 0 comments · Fixed by #9772
Labels
A-security Area: Relates to security. Something is insecure. team-fairies Nico's team

Comments

@sklppy88
Copy link
Contributor

sklppy88 commented Apr 25, 2024 •
edited
Loading

Right now we can import and compute the hash of a contract artifact with unsorted output functions. We need to make sure these are deterministic before hashing it otherwise we end up with an artifact with different hashes but the same input.

Search TODO: #6021
Related to #5875.
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 25, 2024
@LHerskind LHerskind mentioned this issue Jun 14, 2024
Merged
@spalladino spalladino mentioned this issue Oct 28, 2024
Open
5 tasks
@sklppy88 sklppy88 linked a pull request Nov 11, 2024 that will close this issue
fix: sorting artifact props and members in metadata #9772
Merged
@sklppy88 sklppy88 mentioned this issue Nov 13, 2024
Merged
@sklppy88 sklppy88 added team-fairies Nico's team A-security Area: Relates to security. Something is insecure. labels Nov 14, 2024
sklppy88 added a commit that referenced this issue Nov 19, 2024
@sklppy88
fix: add zod parsing for generated contract artifacts (#9905)
e1ef998 
This PR enables us to enforce deterministic contract artifact JSON
stringifying. This is because now when we generate our contract
artifact, we pass it through our zod parser, which enforces ordering in
the object, and enforces correct ordering of props in objects. This is
related to #6021, which we need for deterministic artifact hashes.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-security Area: Relates to security. Something is insecure. team-fairies Nico's team
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sorting artifact props and members in metadata AztecProtocol/aztec-packages
1 participant
@sklppy88