Debug symbols too large #10546
Labels
T-bug
Type: Bug. Something is broken.
Comments
|
These are the current big debug_symbols functions:
|
iAmMichaelConnor
added a commit
that referenced
this issue
Dec 10, 2024
Remove outgoing logs from aztec.nr. Remove outgoing note discovery flows from typescript-land. Outgoing viewing keys are retained, but now aren't used anywhere. 2 weird problems encountered on this journey: - #10546 <-- an inexplicable blow-up in the debug_symbols field of two functions in the StateFulTestContract, despite features only being removed from that contract. - #10558 <-- a debug log keeping the NFT contract from breaking --------- Co-authored-by: Jan Beneš <[email protected]>
AztecBot
pushed a commit
to AztecProtocol/aztec-nr
that referenced
this issue
Dec 11, 2024
Remove outgoing logs from aztec.nr. Remove outgoing note discovery flows from typescript-land. Outgoing viewing keys are retained, but now aren't used anywhere. 2 weird problems encountered on this journey: - AztecProtocol/aztec-packages#10546 <-- an inexplicable blow-up in the debug_symbols field of two functions in the StateFulTestContract, despite features only being removed from that contract. - AztecProtocol/aztec-packages#10558 <-- a debug log keeping the NFT contract from breaking --------- Co-authored-by: Jan Beneš <[email protected]>
lucasxia01
pushed a commit
that referenced
this issue
Dec 11, 2024
Remove outgoing logs from aztec.nr. Remove outgoing note discovery flows from typescript-land. Outgoing viewing keys are retained, but now aren't used anywhere. 2 weird problems encountered on this journey: - #10546 <-- an inexplicable blow-up in the debug_symbols field of two functions in the StateFulTestContract, despite features only being removed from that contract. - #10558 <-- a debug log keeping the NFT contract from breaking --------- Co-authored-by: Jan Beneš <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As part of #10486, the
debug_symbolsfield of some contracts, inexplicably grew to be larger than the string limit of the system. In particular, theStatefulTestcontract, functioncreate_note_no_init_checkandcreate_note. If you look at the first function, it doesn't look like it should have a massivedebug_symbolsfield, given the amount of extra stuff that many other functions do:Within
foundation/src/abi/abi.ts, the functiongetFunctionArtifactcallsgetFunctionDebugMetadata, which tries toinflatethedebug_symbolsstring, and that's where this error arises.I chatted with @sirasistant briefly, and we couldn't figure out why this is happening. Possibly a Noir compiler bug in the way it creates debug_symbols?
For now, within the PR, I just gracefully catch the error and throw a warning. In such cases, the debugMetadata is not returned from
getFunctionDebugMetadatafunction; insteadundefinedis returned (which was an already-possible option for the function anyway).The text was updated successfully, but these errors were encountered: