Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more strict type illusterationkind and prop drill classname an… #367

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

axis-d0op
Copy link
Contributor

@axis-d0op axis-d0op commented Dec 4, 2024

  • illustration prop is now not "string", strictly typed so you can only pick illustration supported (cant infer type, hence hardcoded list of keys)
  • able to prop-drill style and classname props, so u dont have to wrap component if u want to make minor tweaks to its root style
  • added media illustation to constant list

notice:

  • we should export all illustration names from illustration repo in future, so we can use them as keys instead, but for now, constant list is fine ;)

@axis-d0op axis-d0op requested a review from a team as a code owner December 4, 2024 11:10
components/empty-view/src/constants.ts Outdated Show resolved Hide resolved
components/empty-view/src/styles.ts Outdated Show resolved Hide resolved
components/empty-view/src/types.ts Show resolved Hide resolved
@axis-d0op axis-d0op merged commit 289a7ee into main Dec 4, 2024
4 checks passed
@axis-d0op axis-d0op deleted the empty-view-update branch December 4, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants