Update ci workflow #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvrsantacruz
commented
Jul 9, 2024
| @@ -1,9 +1,6 @@ | |||
| [tox] | |||
| envlist = py{3.8,3.9,3.10,3.11,3.12}-{lint,test}-{basic,yaml,hcl} | |||
| skip_missing_interpreters = true | |||
| # Prevent Tox from ignoring `deps` and installing the package (without | |||
| # development dependencies) in the environment | |||
| skipsdist = true | |||
There was a problem hiding this comment.
@frank-lenormand We don't need the app installed for the linting but we do for the cli tests cases.
There was a problem hiding this comment.
I added this line because Tox was ignoring the requirements files entirely, and installing the package itself in the virtual environment directly.
mypy is pinned in dev-requirements.txt, and this option is only defined in the [tox] section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old travis and move to github actions.