Fix slider behaviour for bigger thumbs #7016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thumb now moves synchronously with pointer instead of relativ to track position.
|
|
schauerte
approved these changes
Nov 25, 2021
danwalmsley
pushed a commit
that referenced
this pull request
Dec 7, 2021
Fix slider behaviour for bigger thumbs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR improves / fixes the behaviour of the slider control, which behaves stranger the bigger the thumb becomes. Dragging the thumb, it now moves synchronusly with the pointer all the time.
What is the current behavior?
Dragging the thumb, it always jumps to the right side of ther mouse pointer, while dragging to the maximum value, the thumb slowly moves to the left side of the pointer. This feels strange and not intuitive.
What is the updated/expected behavior with this PR?
Add a slider and drag the thumb. No more jumping to one side of the pointer will occure.
Fixed issues
Fixes #7011