Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTools] Allowed to take a screenshot of the currently selected control. #4762

Merged

Conversation

workgroupengineering
Copy link
Contributor

@workgroupengineering workgroupengineering commented Sep 28, 2020

What does the pull request do?

immagine

  • Create a screenshot when you press F8 or prsss Button SHot
  • Allow Custom Screenshot handelr. The default handler il FileHandler that take a screenshot with this convention:
    • The screenshot is stored using this format [Picture]\Screenshots[App Name][Verision][window][yyyyMMddHHmmss].png
    • [Picture]: is Environment.SpecialFolder.MyPictures.
    • [App Name]: is AssemblyProductAttribute, if missing it uses the name of the currently executing assembly.
    • [Verision]: using AssemblyInformationalVersionAttribute, AssemblyVersionAttribute in order.
    • [window]: the name of the window type of the control I took the screenshot of, es: MainWindow
    • [yyyyMMddHHmmssfff]: datetime.now in iso format.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Fixed issues

Fixes #4743

@pr8x
Copy link
Contributor

pr8x commented Sep 28, 2020

What would be the use case of this?

@workgroupengineering
Copy link
Contributor Author

I am using while reviewing the UI.

@grokys
Copy link
Member

grokys commented Oct 5, 2020

Hm, not sure - this feels like niche functionality that will quickly code-rot due to lack of use. You say:

I am using while reviewing the UI.

Could you give some more details? What are you using it for when reviewing the UI? Reviewing which UI in which way?

More importantly why can't you use OS-provided screenshot functionality?

@workgroupengineering
Copy link
Contributor Author

In the pre-production sentence, if you identify an incorrect UI behavior with this feature, you will quickly highlight the problem by providing a common approach regardless of the operating system and the installed utility, highlighting a post production to crop the image.

In the future, we may add functionality to report a possible problem found by email or by issuing a ticket in Issue Tracker.

@workgroupengineering workgroupengineering force-pushed the features/DevTools/Screenshot branch from b21a95f to 32b45de Compare March 1, 2021 09:36
@maxkatz6 maxkatz6 enabled auto-merge (squash) December 29, 2021 23:53
@maxkatz6 maxkatz6 merged commit eab9659 into AvaloniaUI:master Dec 30, 2021
@workgroupengineering workgroupengineering deleted the features/DevTools/Screenshot branch December 30, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants