-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DevTools] Allowed to take a screenshot of the currently selected control. #4762
[DevTools] Allowed to take a screenshot of the currently selected control. #4762
Conversation
What would be the use case of this? |
I am using while reviewing the UI. |
src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
Hm, not sure - this feels like niche functionality that will quickly code-rot due to lack of use. You say:
Could you give some more details? What are you using it for when reviewing the UI? Reviewing which UI in which way? More importantly why can't you use OS-provided screenshot functionality? |
In the pre-production sentence, if you identify an incorrect UI behavior with this feature, you will quickly highlight the problem by providing a common approach regardless of the operating system and the installed utility, highlighting a post production to crop the image. In the future, we may add functionality to report a possible problem found by email or by issuing a ticket in Issue Tracker. |
b21a95f
to
32b45de
Compare
src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
src/Avalonia.Diagnostics/Diagnostics/ViewModels/MainViewModel.cs
Outdated
Show resolved
Hide resolved
src/Avalonia.Diagnostics/Diagnostics/Views/ControlDetailsView.xaml
Outdated
Show resolved
Hide resolved
src/Avalonia.Diagnostics/Diagnostics/Screenshots/FilePickerHandler.cs
Outdated
Show resolved
Hide resolved
src/Avalonia.Diagnostics/Diagnostics/Screenshots/FileConvetionHandler.cs
Outdated
Show resolved
Hide resolved
…properties to ctor
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Fixed issues
Fixes #4743