Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pathicon #4761

Merged
merged 6 commits into from
Sep 28, 2020
Merged

Feature/pathicon #4761

merged 6 commits into from
Sep 28, 2020

Conversation

danwalmsley
Copy link
Member

What does the pull request do?

Adds a conveniant way to do icons in avalonia using paths.

What is the current behavior?

takes a lot of boiler plate.

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Fixed issues

Copy link
Member

@jmacato jmacato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK :) (im gonna use bitcoin core/ wasabi approval slang from now on haha)

Copy link
Member

@maxkatz6 maxkatz6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmacato jmacato merged commit 090f62a into master Sep 28, 2020
@jmacato jmacato deleted the feature/pathicon branch September 28, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants