Don't check if intent is declared by app before launch #17571
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
In general, on newer android apps, Google recommends that any intent an app will launch be declared at build time in the apps manifest. Apps then check availability of app that can handle that intent before launching. This avoids having to write exception handlers to catch failed intents.
This works fine for normal apps with limited scope. But for a general purpose app framework like Avalonia, it limits the types of applications it can create. File managers, browsers and text editors may not know at build time all the possible intents a Uri could support. In this case, simply starting the intent, catching any exception that may be thrown from missing activities and hoping the user has an app to handle it is more preferable.
For security reasons, it's still recommended for apps to declare intents they use when they can.
What is the current behavior?
What is the updated/expected behavior with this PR?
No longer try to resolve whether an intent can be handled by an activity, but instead try to start an activity anyway and catch expected errors from wrong intents or missing activity.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #17265