Fix TreeViewItem Expand/Collapse event source #17558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
MrJul
added
bug
backport-candidate-11.2.x
maxkatz6
pushed a commit
that referenced
this pull request
Nov 26, 2024
* test: add two fail tests. * fix: fix Expand/Collapse event source.
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
What is the current behavior?
After #16984, TreeView can now subscribe to children Expand/Collapse event. But there are two issues for the implementation.
TreeViewItemitself doesn't raise any event to subscribe.What is the updated/expected behavior with this PR?
By subscribing to the
TreeViewItem.ExpandorTreeViewItem.Collapseevent, developer should know which exactly TreeViewItem is raising the event.How was the solution implemented (if it's not obvious)?
Simply raise the event from TreeViewItem. since it's
Bubble|Tunnel,TreeViewcan still catch it.Two fail unit tests have been added to address the issue.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues