Fixes an issue that can cause Avalonia-based Windows applications to crash on termination #17190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he GetMessage call in RunLoop() of WinUiCompositorConnection.cs has been updated to process the result of GetMessage, and terminate the message loop if a WM_QUIT message is received on the pump. Presently the WM_QUIT message is ignored and the loop re-enters the GetMessage call, causing an unmanaged exception and process crash. AvaloniaUI#17188
|
You can test this PR using the following package version. |
|
|
@cla-avalonia agree |
MrJul
approved these changes
Oct 4, 2024
MrJul
added
the
backport-candidate-11.2.x
maxkatz6
pushed a commit
that referenced
this pull request
Oct 27, 2024
…he GetMessage call in RunLoop() of WinUiCompositorConnection.cs has been updated to process the result of GetMessage, and terminate the message loop if a WM_QUIT message is received on the pump. (#17190) Presently the WM_QUIT message is ignored and the loop re-enters the GetMessage call, causing an unmanaged exception and process crash. #17188
maxkatz6
added
backported-11.2.x
and removed
backport-candidate-11.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
The GetMessage call in RunLoop() of WinUiCompositorConnection.cs has been updated to process the result of GetMessage, and terminate the message loop if a WM_QUIT message is received on the pump.
What is the current behavior?
Presently the WM_QUIT message is ignored and the loop re-enters the GetMessage call, causing an unmanaged exception and process crash.
What is the updated/expected behavior with this PR?
The loop terminates without throwing an error when windows is signalling the message pump to stop.
How was the solution implemented (if it's not obvious)?
The logic was copied from the Avalonia dispatcher implementation here, which correctly processes the result of GetMessage
Checklist
Breaking changes
None
Obsoletions / Deprecations
An optional consideration is to remove the hook to AppDomain.CurrentDomain.ProcessExit that was added as part of PR #9000 / Issue #8261 which is probably redundant now, but doesn't cause any harm having it there
Fixed issues
Fixes #17188
Fixes #8261 (for real this time)