Fixed publishing multi-architecture Android builds #17145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
MrJul
approved these changes
Sep 27, 2024
|
Integration test failures are unrelated. |
Check it instead of DesignTimeBuild
TomEdwardsEnscape
force-pushed
the
fixes/SkipCompilerExecution
branch
from
3332f0e to
d843ae2
Compare
|
You can test this PR using the following package version. |
|
pushed update to my test project to show that it works now (it also builds correctly on the actual project) |
|
This has broken running ControlCatalog.Android on emulator from Rider, considering to revert |
maxkatz6
pushed a commit
that referenced
this pull request
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avalonia now respects the
SkipCompilerExecutionproperty. This fixes multi-architecture Android builds, in which the path to the intermediate assembly, which has already been transformed once, is passed to each inner build and then transformed again.If compiler execution is being skipped then the presence of compiled output cannot be relied on, so not transforming the assembly paths seems harmless to me. This property check can replace
DesignTimeBuildas both are passed at the same time.The Android SDK passes the assembly path like this:
Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
Fixes #17099