Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin with DisableRuntimeMarshalling support + fix macOS Metal AOT #17116

Merged
merged 6 commits into from
Sep 25, 2024
Merged

Begin with DisableRuntimeMarshalling support + fix macOS Metal AOT #17116

merged 6 commits into from
Sep 25, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Sep 24, 2024 •
edited
Loading

What does the pull request do?

  1. Sets DisableRuntimeMarshalling on every trimmable project, unless this project specified otherwise explicitly.
  2. Sets EnableRuntimeMarshalling (custom prop) on every project, where runtime marshalling is still necessary (no need to do everything in one sit)
  3. Makes Avalonia.Base and Avalonia.Skia compatible with DisableRuntimeMarshalling
  4. As part of №3, fixes 11.2.0-beta2 NativeAOT app fails to start on macOS Sequoia / .NET 9.0-rc1 #17090

Fixed issues

Part #16273
Fixes #17090

@maxkatz6 maxkatz6 added enhancement area-infrastructure Issues related to CI/tooling infrastructur area-trimming-aot backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Sep 24, 2024
@maxkatz6 maxkatz6 requested a review from kekekeks September 24, 2024 23:29
@maxkatz6 maxkatz6 changed the title Begin with DisableRuntimeMarshalling support Begin with DisableRuntimeMarshalling support + fix macOS Metal AOT Sep 24, 2024
@maxkatz6 maxkatz6 mentioned this pull request Sep 24, 2024
Open
7 tasks
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0052086-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added customer-priority Issue reported by a customer with a support agreement. and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Sep 25, 2024
@MrJul MrJul added this pull request to the merge queue Sep 25, 2024
Merged via the queue into master with commit d7040e2 Sep 25, 2024
12 checks passed
@MrJul MrJul deleted the begin-disable-runtime-marshalling branch September 25, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrJul MrJul MrJul approved these changes

@kekekeks kekekeks kekekeks approved these changes

Assignees
No one assigned
Labels
area-infrastructure Issues related to CI/tooling infrastructur area-trimming-aot customer-priority Issue reported by a customer with a support agreement. enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

11.2.0-beta2 NativeAOT app fails to start on macOS Sequoia / .NET 9.0-rc1
4 participants
@maxkatz6 @avaloniaui-bot @kekekeks @MrJul