Fix ClickOnce entry assembly not having Avalonia XAML compilation output #17115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… XAML compilation output
TomEdwardsEnscape
force-pushed
the
fixes/clickonce-publish-entrypoint
branch
from
b5a670b to
d0adb91
Compare
|
You can test this PR using the following package version. |
MrJul
approved these changes
Sep 25, 2024
MrJul
added
area-infrastructure
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClickOnce records the "entry point assembly" at evaluation time. This means that even though our
InjectAvaloniaXamlOutputtarget executes at the correct time, there is a copy of the original file path that it doesn't know about and so can't update. As a result, the assembly being published doesn't have XAML compile output (all referenced assemblies are OK though).What is the updated/expected behavior with this PR?
We now update the ClickOnce item.
Breaking changes
None.
Obsoletions / Deprecations
None.
Fixed issues
Fixes #16732