Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the client area when a Win32 window is opened in maximised state #16593

Merged

Conversation

TomEdwardsEnscape
Copy link
Contributor

#16029 fixed the internal show/hide state not being updated when a window opens in a maximised state, but it didn't extend the client area in the same circumstances. This PR adds the required calls.

Breaking changes

None

Obsoletions / Deprecations

None

Fixed issues

Fixes #16503

@maxkatz6
Copy link
Member

maxkatz6 commented Aug 5, 2024

Do you think it would be difficult to add an integrational test for this case?
https://github.com/AvaloniaUI/Avalonia/blob/master/tests/Avalonia.IntegrationTests.Appium/WindowDecorationsTests.cs

I assume PInvoke to get current actual window position would be needed as well.

On how to run these tests https://github.com/AvaloniaUI/Avalonia/tree/master/tests/Avalonia.IntegrationTests.Appium

@maxkatz6 maxkatz6 added bug os-windows backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 5, 2024
@TomEdwardsEnscape
Copy link
Contributor Author

I'm not in a position to set that system up on my computer. It would also be difficult for me because I've never used Appium. I'll happily push changes made by someone else to this branch though.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050949-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@emmauss emmauss added this pull request to the merge queue Aug 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 16, 2024
@emmauss emmauss added this pull request to the merge queue Aug 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 16, 2024
@emmauss emmauss added this pull request to the merge queue Aug 16, 2024
Merged via the queue into AvaloniaUI:master with commit 8a61eca Aug 16, 2024
11 checks passed
@TomEdwardsEnscape TomEdwardsEnscape deleted the fixes/maximised-extended-clientarea branch August 18, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch bug os-windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caption Buttons disappearing
4 participants