Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase LayoutTransformControl.DecimalsAfterRound from 4 to 8 #16583

Merged

Conversation

BobLd
Copy link
Contributor

@BobLd BobLd commented Aug 3, 2024

As discussed with @maxkatz6 in #16499

What does the pull request do?

Increase LayoutTransformControl.DecimalsAfterRound property from 4 to 8

What is the current behavior?

LayoutTransformControl with very large object and zoom creates imprecision artefact due to the transformation matrix being rounded to 4 decimal places

What is the updated/expected behavior with this PR?

Being able to use the LayoutTransformControl in very large objects.

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050881-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

Copy link
Member

@MrJul MrJul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
As per #16499 (reply in thread), won't be backported to 11.1.

@MrJul MrJul enabled auto-merge August 3, 2024 09:04
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050887-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@MrJul MrJul added this pull request to the merge queue Aug 3, 2024
Merged via the queue into AvaloniaUI:master with commit a6c446d Aug 3, 2024
10 checks passed
@BobLd BobLd deleted the LayoutTransformControl-DecimalsAfterRound branch August 3, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants