Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow binding DataGridRow.IsSelected #16520

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

grokys
Copy link
Member

@grokys grokys commented Jul 29, 2024

What does the pull request do?

Previously DataGridRow.IsSelected was an internal readonly property. In the WPF DataGrid however, this is a public bindable property. Update our implementation to allow this, and added a few unit tests.

Fixed issues

Fixes #15176

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050594-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@grokys grokys marked this pull request as ready for review July 31, 2024 08:31
@grokys grokys added the customer-priority Issue reported by a customer with a support agreement. label Jul 31, 2024
@grokys
Copy link
Member Author

grokys commented Jul 31, 2024

Customer has said that this works for them, so ready for review.

@maxkatz6 maxkatz6 added this pull request to the merge queue Aug 1, 2024
Merged via the queue into master with commit b1489aa Aug 1, 2024
12 checks passed
@maxkatz6 maxkatz6 deleted the feature/datagridrow-isselected-binding branch August 1, 2024 11:11
@grokys grokys added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Aug 2, 2024
grokys added a commit that referenced this pull request Aug 2, 2024
* Change namespace to prevent conflicts.

The `DataGrid` in the namespace name was hiding the `DataGrid` type.

* Initial impl of bindable DataGridRow.IsSelected.

* Make DataGridRow.IsSelected two-way bindable.
@grokys grokys added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-datagrid backported-11.1.x customer-priority Issue reported by a customer with a support agreement. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DataGrid] Add DataGridRow.IsSelected
3 participants