Android - Refactor AvaloniaInputConnection #16490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Rewrite parts of AndroidInputConnection to respond to android input more accurately. This implementation is based on compose's InputConnection implementation.
What is the current behavior?
Our current implementation is compatible with GBoard due to its low use of composition apis. But not with some other keyboards, like SwiftKey, that makes extensive use of text composition and prediction. As such, words were being skipped or misplaced in those keyboards.
What is the updated/expected behavior with this PR?
A command queue is now being used to batch ime edits. Each command corresponds to an ime action that would affect the text buffer, like composition, commit, and selection updates. If a batch edit is active(common for composition keyboard like SwiftKey), only when batch edit ends would updates be run on the buffer.
Commands that are run affect the text buffer directly, and updates are forwarded to TextInputMethodClient immediately.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #16392