Fix context menu keyboard selection. #16354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by #11287. The fix is to make the `ContextMenu` focusable. Added an integration test to try to prevent regressions.
grokys
added
bug
customer-priority
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Jul 17, 2024
|
You can test this PR using the following package version. |
grokys
added a commit
that referenced
this pull request
Jul 23, 2024
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by #11287. The fix is to make the `ContextMenu` focusable. Added an integration test to try to prevent regressions. Co-authored-by: Max Katz <[email protected]>
Gillibald
pushed a commit
to Gillibald/Avalonia
that referenced
this pull request
Jul 29, 2024
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by AvaloniaUI#11287. The fix is to make the `ContextMenu` focusable. Added an integration test to try to prevent regressions. Co-authored-by: Max Katz <[email protected]>
Gillibald
pushed a commit
that referenced
this pull request
Jul 30, 2024
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by #11287. The fix is to make the `ContextMenu` focusable. Added an integration test to try to prevent regressions. Co-authored-by: Max Katz <[email protected]>
grokys
added a commit
that referenced
this pull request
Jul 31, 2024
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by #11287. The fix is to make the `ContextMenu` focusable. Added an integration test to try to prevent regressions. Co-authored-by: Max Katz <[email protected]>
grokys
added
backport-candidate-11.0.x
grokys
added a commit
that referenced
this pull request
Aug 2, 2024
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by #11287. The fix is to make the `ContextMenu` focusable. Added an integration test to try to prevent regressions. Co-authored-by: Max Katz <[email protected]>
grokys
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
When opening a context menu and pressing the "arrow down" key, the first menu item was not selected. This issue was introduced by #11287. The fix is to make the
ContextMenufocusable.Added an integration test to try to prevent regressions.