Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Win32 - Fix window size and position for border only window when maximized through OS means #16297

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

emmauss
Copy link
Contributor

@emmauss emmauss commented Jul 12, 2024

What does the pull request do?

Adjusts a border-less window's position and size after being maximized to fit the window space allowed by the desktop, i.e. not cover the taskbar. This was previously done only for window state changes triggered by avalonia apis. This pr applies the update to maximization triggered by the OS, like using the Win+Up key combination.

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

Fixes #11685

@emmauss emmauss force-pushed the fix/win32_no_border_window_maximize branch from 6c41aed to 168d561 Compare July 12, 2024 11:17
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050040-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@timunie
Copy link
Contributor

timunie commented Jul 14, 2024

Does it fix #16307

@emmauss
Copy link
Contributor Author

emmauss commented Jul 15, 2024

Does it fix #16307

The issue doesn't seem to occur as of the latest master.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050115-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0050158-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@emmauss emmauss enabled auto-merge July 16, 2024 10:43
@maxkatz6 maxkatz6 added bug backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jul 17, 2024
@maxkatz6 maxkatz6 disabled auto-merge July 17, 2024 02:58
@maxkatz6 maxkatz6 merged commit 5521baa into master Jul 17, 2024
9 of 11 checks passed
@maxkatz6 maxkatz6 deleted the fix/win32_no_border_window_maximize branch July 17, 2024 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drag/Dropping Window to Maximized Cuts Taskbar (BorderOnly Deco)
5 participants