Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix XML child-value syntax in Setters #16153

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Fix XML child-value syntax in Setters #16153

merged 1 commit into from
Jul 28, 2024

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

    <Setter Property='Margin'>10, 4, 0, 4</Setter>

As far as I can tell, this syntax was never supported, but I don't see why it shouldn't.

Checklist

Fixed issues

Fixes #3799

@maxkatz6 maxkatz6 added bug area-xaml backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Jun 27, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049530-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented Jun 28, 2024

It was always strange to me this wasn't supported. I just worked around it and moved on. It's nice it's added now for XAML compatibility!

@maxkatz6
Copy link
Member Author

@robloo honestly, I didn't know it's not supported/is broken, until I found this 4 years old issue.

@MrJul MrJul added this pull request to the merge queue Jul 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 28, 2024
@MrJul MrJul added this pull request to the merge queue Jul 28, 2024
Merged via the queue into master with commit 2935763 Jul 28, 2024
12 checks passed
@MrJul MrJul deleted the setter-value-parser-bug branch July 28, 2024 13:31
@maxkatz6 maxkatz6 removed the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set value for <Setter> inside <Setter>here</Setter>
4 participants