-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented VulkanDevice.Dispose #15936
Conversation
You can test this PR using the following package version. |
|
@cla-avalonia agree |
@jp2masa thank you. I wonder how useful is RenderDoc with Avalonia. Or do you use it for embedded 3d rendering? |
Exactly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we still should be cautious with this, since we have to destroy any objects created with that device.
What does the pull request do?
Implemented
VulkanDevice.Dispose
, callingvkDestroyDevice
.What is the current behavior?
When using the Vulkan backend, at least 2
VkDevice
s are created, one for initialization and one for rendering. The initialization one is always leaked, becauseDispose
is called, but it is not implemented.What is the updated/expected behavior with this PR?
VkDevice
perVkInstance
)VkDevice
s are no longer leakedHow was the solution implemented (if it's not obvious)?
It's obvious
Checklist
Breaking changes
N/A
Obsoletions / Deprecations
N/A
Fixed issues
Fixes #15926