Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avalonia.Native TopLevel embedding #15932

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Avalonia.Native TopLevel embedding #15932

merged 2 commits into from
Jun 19, 2024

Conversation

Gillibald
Copy link
Contributor

@Gillibald Gillibald commented Jun 6, 2024 •
edited
Loading

What does the pull request do?

This PR introduces a TopLevelImpl for the Avalonia.Native backend. The WindowBaseImpl previously implemented this layer.

This makes it possible to have more embedding solutions that only require an NSView.

Ime interaction with Popups is also fixed. Only the Popup's parent window is the key window so that is responding to key events but Avalonia isn't using the parent's text input method. Hence, we must pretend the Popup's input method is the parent's.

Sample: https://github.com/AvaloniaUI/Xamarin.Mac.Interop

What is the current behavior?

What is the updated/expected behavior with this PR?

How was the solution implemented (if it's not obvious)?

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048965-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048984-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@Gillibald Gillibald mentioned this pull request Jun 13, 2024
Closed
3 tasks
@Gillibald Gillibald changed the title [WIP] Avalonia.Native TopLevel embedding Avalonia.Native TopLevel embedding Jun 13, 2024
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049041-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049103-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049108-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049150-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 merged commit 143399f into AvaloniaUI:master Jun 19, 2024
10 checks passed
Gillibald added a commit to Gillibald/Avalonia that referenced this pull request Jul 29, 2024
@Gillibald
Avalonia.Native TopLevel embedding (AvaloniaUI#15932)
8a6aedd 
* Introduce Avalonia.Native TopLevelImpl

* Update Avalonia.Native.csproj

Revert change
Gillibald added a commit that referenced this pull request Jul 30, 2024
@Gillibald
Avalonia.Native TopLevel embedding (#15932)
a3a1668 
* Introduce Avalonia.Native TopLevelImpl

* Update Avalonia.Native.csproj

Revert change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jp2masa jp2masa jp2masa left review comments

@kekekeks kekekeks kekekeks left review comments

@maxkatz6 maxkatz6 maxkatz6 approved these changes

Assignees
No one assigned
Labels
enhancement feature os-macos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gillibald @avaloniaui-bot @kekekeks @maxkatz6 @jp2masa