More trimming fixes, enable analyzers unconditionally #15815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
After that PR simple Avalonia Hello World produces 0 trimming related warnings/errors in AOT mode.
Note, even before this PR all of these warnings were false positives, without actual runtime errors. But it's always nicer to avoid warnings.
What was changed in this PR:
#pragma warning disable
, when UnconditionalSuppressMessage should be used. Otherwise suppressions won't be respected in NAOT compilation.TODO:
Not related to warnings, but we can improve output binary size by respecting IsDynamicCodeSupported property in more places. But even better to wait until feature switches in .NET 9, so whole reflection bindings related codebase can be disabled and trimmed out.
We also should start running some tests with AOT enabled. MSTest might be required to do so, since xUnit doesn't support AOT yet.
Fixed issues
Fixes #13897
Fixes #11727