Hack to enable subpixel rendering by default. #15676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grokys
added
bug
backport-candidate-11.1.x
|
You can test this PR using the following package version. |
kekekeks
approved these changes
May 11, 2024
grokys
added a commit
that referenced
this pull request
Jun 3, 2024
grokys
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
As described in #15015: since #14806 was merged our text rendering is unable to use subpixel rendering because the API to enable subpixel rendering on layers is not exposed by SkiaSharp.. This can be fixed by setting
CompositionOptions.UseSaveLayerRootClip = falseto disable the root layer, but the current default means that subpixel rendering is disabled by default.Given that blurry fonts are a lot more noticeable than the (rare?) rendering glitches reported in #14270, this PR changes the default.
Until the required API is added to SkiaSharp you have to choose between #15015 and #14270, unfortunately.
What is the current behavior?
Blurry fonts but no rendering glitches.
What is the updated/expected behavior with this PR?
Non-blurry fonts but rare rendering glitches.
Fixed issues
Fixes #15015