Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dedicated automation peers for TreeView and TreeViewItem #15653

Conversation

wieslawsoltes
Copy link
Collaborator

@wieslawsoltes wieslawsoltes commented May 8, 2024

What does the pull request do?

Adds dedicated automation peers for TreeView and TreeViewItem

What is the current behavior?

No dedicated automation peers for TreeView and TreeViewItem

What is the updated/expected behavior with this PR?

TreeView and TreeViewItem have dedicated automation peers

image

image

How was the solution implemented (if it's not obvious)?

Created dedicated automation peers for Add dedicated automation peers for TreeView and TreeViewItem

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048185-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@jmacato jmacato requested a review from grokys May 8, 2024 10:24
Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start. According to the UIA docs) there are a few other things that should be implemented but these can be added later IMO:

  • tree should also support ISelectionProvider
  • tree view items should also support IExpandCollapseProvider and ISelectionItemProvider

@wieslawsoltes
Copy link
Collaborator Author

Looks like a good start. According to the UIA docs) there are a few other things that should be implemented but these can be added later IMO:

  • tree should also support ISelectionProvider

  • tree view items should also support IExpandCollapseProvider and ISelectionItemProvider

Yes those things can be added later, priority was to at least get proper structure for now.

@grokys grokys added this pull request to the merge queue May 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 9, 2024
@maxkatz6 maxkatz6 merged commit 6aacd55 into AvaloniaUI:master May 13, 2024
10 checks passed
@maxkatz6 maxkatz6 added enhancement area-accessibility backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 13, 2024
@maxkatz6 maxkatz6 added feature and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants