Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android][TextBox] fix strange caret move behaviour on Android 14 #15605

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented May 4, 2024

What does the pull request do?

Only delete compositionText when there is compositionText

What is the current behavior?

On Android 14, move caret left or right might delete a character from the text box.

Screenrecorder-2024-05-04-23-07-05-899.mp4

What is the updated/expected behavior with this PR?

On Android 14, move caret left or right won't delete a character from the text box.

How was the solution implemented (if it's not obvious)?

Only delete compositionText when there is compositionText

Checklist

Breaking changes

Obsoletions / Deprecations

Fixed issues

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0048074-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 requested review from Gillibald and emmauss May 4, 2024 23:58
@maxkatz6 maxkatz6 added this pull request to the merge queue May 6, 2024
Merged via the queue into AvaloniaUI:master with commit 0d4fbe1 May 6, 2024
11 checks passed
@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label May 7, 2024
maxkatz6 pushed a commit that referenced this pull request May 8, 2024
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants