Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] WindowDecorations related integration tests #15561

Merged
merged 12 commits into from
Jun 28, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Apr 30, 2024

What does the pull request do?

  1. Enabled avalonia name source generator in integration tests project.
  2. Implements basic TitleBarAutomationNode.
  3. Creates some basic tests for WindowDecorations:
  • Toggling window decorations shouldn't change window size. (disabled, as it's broken right now)
  • Client-side chrome title bar height tests.
  • Server-side chrome title bar height tests.
  • Client-side chrome title bar height tests for a new window. This test is failing if Win32 - Fix EntendClient hints not being applied window show #15552 is reverted.

No macOS tests for now. Maybe in another PR Done.

What is the current behavior?

No tests. Only manual, only hardcore.

What is the updated/expected behavior with this PR?

I can sleep better. A little bit.

Checklist

Fixed issues

Tests #15532
Tests #15522
Tests #15552

@maxkatz6 maxkatz6 added enhancement os-windows backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 30, 2024
@maxkatz6 maxkatz6 force-pushed the integration-tests-updates branch 2 times, most recently from 5c43f68 to 8033719 Compare April 30, 2024 07:14
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047904-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047916-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 force-pushed the integration-tests-updates branch from e2afa53 to 01fbe57 Compare April 30, 2024 20:55
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047938-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 force-pushed the integration-tests-updates branch from 01fbe57 to 14e8376 Compare May 1, 2024 01:24
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047960-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047964-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 requested a review from grokys May 1, 2024 08:02
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047970-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@robloo
Copy link
Contributor

robloo commented May 3, 2024

This is great! Thanks for taking the time to add these!

Copy link
Member

@grokys grokys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @maxkatz6, sorry it took so long to get to this.

@grokys grokys added this pull request to the merge queue Jun 25, 2024
@maxkatz6 maxkatz6 removed this pull request from the merge queue due to a manual request Jun 25, 2024
…pdates

# Conflicts:
#	tests/Avalonia.IntegrationTests.Appium/WindowTests.cs
@maxkatz6 maxkatz6 enabled auto-merge June 26, 2024 07:55
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0049478-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

…pdates

# Conflicts:
#	samples/IntegrationTestApp/MainWindow.axaml.cs
@maxkatz6 maxkatz6 force-pushed the integration-tests-updates branch from a0286f3 to 3a93772 Compare June 28, 2024 03:40
@maxkatz6 maxkatz6 disabled auto-merge June 28, 2024 03:41
@maxkatz6 maxkatz6 merged commit d4d3226 into master Jun 28, 2024
2 of 10 checks passed
@maxkatz6 maxkatz6 deleted the integration-tests-updates branch June 28, 2024 03:41
@maxkatz6 maxkatz6 removed the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants