Make SelectionModel.SelectedItems and SelectedIndexes implement INCC.
#15498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make `SelectionModel.SelectedItems` and `SelectionModel.SelectedIndexes` implement `INotifyCollectionChanged` so that they can be bound to. As well as implementing `INotifyCollectionChanged` on the collections, we also had to implement `IList` (see #8764) so refactored this out into a base class. For the sake of simplicity, these collections only raise `Reset` for any change: this is may need to be changed later but I'd rather follow the KISS principle for the moment until something more complex is proven necessary. Fixes #15497
grokys
added
enhancement
customer-priority
grokys
changed the title
SelectionModel.SelectedItems and SelectedIndexes implement INCC.
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
approved these changes
Apr 24, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Apr 25, 2024
Make `SelectionModel.SelectedItems` and `SelectionModel.SelectedIndexes` implement `INotifyCollectionChanged` so that they can be bound to. As well as implementing `INotifyCollectionChanged` on the collections, we also had to implement `IList` (see #8764) so refactored this out into a base class. For the sake of simplicity, these collections only raise `Reset` for any change: this is may need to be changed later but I'd rather follow the KISS principle for the moment until something more complex is proven necessary. Fixes #15497
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Make
SelectionModel.SelectedItemsandSelectionModel.SelectedIndexesimplementINotifyCollectionChangedso that they can be bound to.As well as implementing
INotifyCollectionChangedon the collections, we also had to implementIList(see #8764) so refactored this out into a base class.For the sake of simplicity, these collections only raise
Resetfor any change: this is may need to be changed later but I'd rather follow the KISS principle for the moment until something more complex is proven necessary.Fixed issues
Fixes #15497