Fix app shutdown cancellation via window #15438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
bug
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Apr 19, 2024
maxkatz6
added a commit
that referenced
this pull request
Apr 20, 2024
* Don't call dispatcher shutdown, when app shutdown was cancelled * Assert Dispatcher.UIThread.ShutdownStarted in TryShutdown_Cancellable_By_Preventing_Window_Close
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
maxkatz6
removed
the
backport-candidate-11.0.x
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
App shutdown method is supposed to be cancelled, if at least one window did cancel this event.
When at least one window is cancelled, TryShutdown was returning false as expected. Unfortunately, dispatcher was still killed in the same method in finalizer that was always executing.
Checklist
Fixed issues
Fixes #14748