ComboBox: support different DataTemplate for selected item. #15420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Apr 17, 2024
src/Avalonia.Controls/Converters/MultiDataTemplatesConverter.cs
Outdated
Show resolved
Hide resolved
|
Can we please call this My first thought while reading this PR was that the |
|
Updated according to reviews. |
|
You can test this PR using the following package version. |
|
Other controls call this property ContentTemplate |
maxkatz6
approved these changes
Apr 22, 2024
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 24, 2024
* feat: ComboBox: support different DataTemplate for selected item. * feat: use coerce instead of multi binding. * test: add multiple unit tests.
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Add a new Property SelectedItemTemplate, if set, it has a higher priority than ItemTemplate.
What is the current behavior?
Displayed selected item is always the same as ComboBoxItem
What is the updated/expected behavior with this PR?
Make it possible to use different DataTemplates for selected item and other items.
How was the solution implemented (if it's not obvious)?
Use multibinding and select the first valid IDataTemplate.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues