Fix unable to type cultural character into TextBox #15394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check KeySymbol before return null in TryCreateRawKeyEventArgs to prevent skipping cultural character.
|
You can test this PR using the following package version. |
Gillibald
approved these changes
Apr 16, 2024
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 20, 2024
Check KeySymbol before return null in TryCreateRawKeyEventArgs to prevent skipping cultural character. Co-authored-by: CKPhong <[email protected]>
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check KeySymbol before return null in TryCreateRawKeyEventArgs to prevent skipping cultural character.
What does the pull request do?
This PR makes sure we don't skip a special cultural character when it's typed using custom cultural tools.
What is the current behavior?
Any special cultural character will be deleted upon typing into Textbox, all keyDown or keyUp events will receive a blank character instead of the special character.
What is the updated/expected behavior with this PR?
Special cultural character should be typed and inserted normally in TextBox.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #13190