Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add StringSyntax attribute to the runtime parser code #15376

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

maxkatz6
Copy link
Member

What does the pull request do?

Marks our public XAML parser APIs with StringSyntaxAttribute:
Useful for tests:
image

Highlights errors as well:
image

And conveniently, Avalonia XAML is a valid XML.

It doesn't work with XAML in local variables:
image

Also doesn't work in Visual Studio at all for some reason.

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0047306-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Apr 16, 2024
Merged via the queue into master with commit 1fe718a Apr 16, 2024
11 checks passed
@maxkatz6 maxkatz6 deleted the xml-syntax-highlight branch April 16, 2024 19:45
@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Apr 20, 2024
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants