Try to combine AvaloniaResources with the same system path #15302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
commented
Apr 10, 2024
Comment on lines
+70
to
71
| [Obsolete] | ||
| public static void WriteResources(Stream output, List<(string Path, int Size, Func<Stream> Open)> resources) |
There was a problem hiding this comment.
Since this method is part of public API, I made it obsolete, and added a new overload with AvaloniaResourcesEntry items.
kekekeks
approved these changes
Apr 10, 2024
|
You can test this PR using the following package version. |
maxkatz6
added
the
backport-candidate-11.1.x
maxkatz6
added a commit
that referenced
this pull request
Apr 20, 2024
* Try to combine AvaloniaResources with the same system path * Fix test assert
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Follow-up PR/optimization after previous PR.
If the same file was included multiple times, but with different path/link, we should try to combine them into a single resource with aliases.
How was the solution implemented (if it's not obvious)?
No changes to the protocol. Just adjust offset properties for duplicated indexes, and don't write the same data twice.
Checklist