Propagate Dispose for ICustomDrawOperation through RenderDataCustomNode. #15224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
maxkatz6
added
backport-candidate-11.0.x
maxkatz6
approved these changes
Apr 4, 2024
3 tasks
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Implements IDisposable on RenderDataCustomNode to propagate Dispose for ICustomDrawOperation.
What is the current behavior?
Currently the rendering system does not call Dispose for ICustomDrawOperation. This makes it difficult to know when a draw operation can free its resources. The deferred renderer can call Render on an ICustomDrawOperation multiple times, and so a draw operation needs to be told when it is ready to be disposed.
What is the updated/expected behavior with this PR?
ICustomDrawOperation.Dispose will be called when the renderer removes a draw operation from the scene.
How was the solution implemented (if it's not obvious)?
Implements IDisposable for RenderDataCustomNode, which leads to Dispose being propagated up to the ICustomDrawOperation.
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #15221
Discussed in #15206