-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes TileBrush transform handling #15157
Fixes TileBrush transform handling #15157
Conversation
I went to see if maybe this PR also fixes #11959 (unfortunately doesn't look like) But additionally, it renders incorrectly again: before the commit More adjustments (might be related to my screen dpi?) After the commit the grid is completely gone: |
Looks like there is no test coverage here. Can you provide me the brush definition that isn't working? |
even with no transform attached. It is completely blank after the latest commit. But it might be due to my screen scaling (macbook retina x2 scaling). Regular grid is expected: |
The PR currently does not handle all Stretch modes that might cause this. Thanks for the sample. |
You can test this PR using the following package version. |
d215e12
to
2e02a1c
Compare
2e02a1c
to
97c115a
Compare
You can test this PR using the following package version. |
You can test this PR using the following package version. |
#Conflicts: # src/Skia/Avalonia.Skia/DrawingContextImpl.cs
What does the pull request do?
What is the current behavior?
What is the updated/expected behavior with this PR?
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues