Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS some pointer/keyboard fixes #15061

Merged
merged 4 commits into from
Mar 20, 2024
Merged

iOS some pointer/keyboard fixes #15061

merged 4 commits into from
Mar 20, 2024

Conversation

maxkatz6
Copy link
Member

@maxkatz6 maxkatz6 commented Mar 20, 2024

What does the pull request do?

  1. Delete/Backspace mapping was wrong
  2. Pen-up state mapping was incorrectly mapped as right-click-down.
  3. Fixes PenPointer.IsPrimary calculation for iOS (other backends should be double checked as well, since old behavior was made specifically for Windows, which is much more flexible with pen input)
  4. Don't limit scroll gesture by only primary pointer

Fixed issues

Fixes #15011
Fixes #14837
Possibly #15019

@maxkatz6 maxkatz6 added bug os-ios backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Mar 20, 2024
@maxkatz6 maxkatz6 merged commit bad2e8d into master Mar 20, 2024
3 of 6 checks passed
@maxkatz6 maxkatz6 deleted the ios-pointer-fixes branch March 20, 2024 21:41
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.2.999-cibuild0046419-alpha. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

maxkatz6 added a commit that referenced this pull request Apr 6, 2024
* Fix stylus input state mapping on iOS

* Fix UIKeyboardHidUsage.KeyboardDeleteOrBackspace mapping on iOS, should be mapped to Backspace

* Release iOS pen pointer on PenUp event, fixing IsPrimary state

* Don't limit scroll gestures to single primary input - user should be able to scroll two different scrolls
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants