Win32 - Only update window position on extended client changed when window is visible #14954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
emmauss
force-pushed
the
fix/win32_force_frame_margin_shown
branch
from
2d1df9c to
207efa1
Compare
emmauss
changed the title
emmauss
force-pushed
the
fix/win32_force_frame_margin_shown
branch
from
207efa1 to
02ebadc
Compare
|
You can test this PR using the following package version. |
emmauss
force-pushed
the
fix/win32_force_frame_margin_shown
branch
from
02ebadc to
50a5f3e
Compare
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Mar 18, 2024
maxkatz6
added
bug
os-windows
backport-candidate-11.1.x
maxkatz6
pushed a commit
that referenced
this pull request
Apr 6, 2024
maxkatz6
added
backported-11.1.x
and removed
backport-candidate-11.1.x
|
|
||
| if (newProperties.Decorations == SystemDecorations.Full) | ||
| if (_shown || forceChanges) |
There was a problem hiding this comment.
This line causes #16529. Remove it and the window opens at the correct location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Only sets frame margins when window is visible.
What is the current behavior?
Currently, when system decorations change, the window frame margins are updated, even if the window is not visible yet. If the window isn't shown yet, and the SystemDecoration property is set after Width/Height are set, it forces a size update, and ClientSize is set before the window's Width and Height is applied, thus discarding the Width/Height properties.
What is the updated/expected behavior with this PR?
If window isn't shown, and decorations have been set, update extended margins, but don't set position yet. But if it's being shown, force a frame update after the initial size is set.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Obsoletions / Deprecations
Fixed issues
Fixes #14942