Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PopupPositionerConstraintAdjustment.ResizeY value #14873

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

MrJul
Copy link
Member

@MrJul MrJul commented Mar 7, 2024

What does the pull request do?

This PR fixes the PopupPositionerConstraintAdjustment.ResizeY which currently has the same value as ResizeX.

Breaking changes

Yes, changing a constant or enum value is a breaking change.

Users that have built binaries before while using PopupPositionerConstraintAdjustment explicitly will experience the equivalent of not having ResizeY set anymore after updating Avalonia without recompiling their assemblies.

While technically breaking, I think it has very low impact.

@maxkatz6 maxkatz6 added the backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch label Mar 7, 2024
@maxkatz6 maxkatz6 enabled auto-merge March 7, 2024 23:53
@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045898-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Mar 8, 2024
Merged via the queue into AvaloniaUI:master with commit fbae909 Mar 8, 2024
6 checks passed
@MrJul MrJul deleted the fix/popup-constraint branch March 8, 2024 11:32
@maxkatz6 maxkatz6 added backported-11.1.x and removed backport-candidate-11.1.x Consider this PR for backporting to 11.1 branch labels Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants