Fix: Crossfade animation causes other animations to have hidden elements #14832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
maxkatz6
reviewed
Mar 6, 2024
|
|
||
| if (from != null) | ||
| { | ||
| from.Opacity = 0f; |
There was a problem hiding this comment.
Another option would be to replace from.Opacity with the same:
disposables.Add(from.SetValue(Visual.OpacityProperty, 0, Data.BindingPriority.Animation)!)
Which should be reverted later, when disposables are disposed. But either way, your PR looks good to me.
There was a problem hiding this comment.
Thanks.
This was my original solution but realised it could be simplified and assumed removing the disposables would be more performant.
maxkatz6
approved these changes
Mar 6, 2024
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Fix for CrossFade animation overwriting opacity causing elements to not show if you change the transition style (eg. PageSlide or none)
What is the current behavior?
When switching transition types on a control (EG. TransitioningContentControl) the opacity change is not reversed. This causes content to not show on other transition types.
This can be tested using the Catalog samples TransitioningContentControl.
Use the cross fade transition and move to another element in the control, then change to none and when transitioning some elements are hidden.
What is the updated/expected behavior with this PR?
Elements will maintain their existing opacity after a transition using CrossFade.
This can be tested using the Catalog samples TransitioningContentControl.
Use the cross fade transition and move to another element in the control, then change to none and when transitioning, elements should show as expected.
How was the solution implemented (if it's not obvious)?
Remove the opacity changes on the to/from Visual components and supporting code as the transition keyframes will take care of the opacity.
Fixed issues
Fixes #14054