Removed ClearRowSelection when action is SelectFromAnchorToCurrent. #14738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-policy-service agree |
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
This PR fixes issue 14737 #14737 by retaining the current selection when selecting a range of rows in DataGrid.
What is the current behavior?
Currently non-consecutive blocks can not be selected because the current selection is cleared when a range is being selected.
What is the updated/expected behavior with this PR?
Removed the call to ClearRowSelection when the DataGridSelectionAction is SelectFromAnchorToCurrent. The logic for selection is already robust to this change i.e. can select ranges forward/backward, cover existing selections, add new items to existing selection etc.
How was the solution implemented (if it's not obvious)?
Removed a single method call.
Checklist
Would like some advice on how to approach unit testing. This doesn't look like it impacts on documentation.
Breaking changes
N/A
Obsoletions / Deprecations
N/A
Fixed issues
Fixes #14737