Share similar XAML dynamic setters #14717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrJul
force-pushed
the
better-setters-cache2
branch
from
e786d3d to
aa15781
Compare
|
You can test this PR using the following package version. |
MrJul
force-pushed
the
better-setters-cache2
branch
from
aa15781 to
e125021
Compare
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
A revival of one of my first PR #8799, aiming at reducing code duplication in the XAML by sharing property setters when appropriate.
XamlDynamicSetterstype and pass it to XamlX when compilingWhat is the current behavior?
The XAML dynamic setters are generated per type/closure, leading to duplication.
What is the updated/expected behavior with this PR?
The XAML dynamic setters are shared between all compiled types in an assembly.
Size changes: