[X11] Allow setting WM_CLASS and _NET_WM_WINDOW_TYPE #14619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 20, 2024
maxkatz6
requested changes
Feb 20, 2024
| Desktop | ||
| } | ||
|
|
||
| public interface IX11SpecificOptionsToplevelImplFeature |
There was a problem hiding this comment.
I checked in ILSpy, and this interface is fully public there in the ref assembly. I suppose our patch tool only looks for "Impl" in the end of the type name.
|
|
||
| namespace Avalonia.Controls; | ||
|
|
||
| public class X11Properties |
maxkatz6
reviewed
Feb 20, 2024
Co-authored-by: Max Katz <[email protected]>
|
You can test this PR using the following package version. |
maxkatz6
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting X11 specific window properties in the same way we are dealing with Win32 ones.
Open questions: why do we have those in Avalonia.Controls.Platform namespace? It's not XAML-visible by default