Fix TemplateBinding and allow custom attributes in XamlValueConverter #14612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
…g-and-allow-attributes-in-XamlValueConverter # Conflicts: # src/Markup/Avalonia.Markup.Xaml.Loader/xamlil.github
|
You can test this PR using the following package version. |
MrJul
reviewed
Mar 19, 2024
Merged
grokys
approved these changes
May 9, 2024
…g-and-allow-attributes-in-XamlValueConverter # Conflicts: # src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/Transformers/AvaloniaXamlIlTransformInstanceAttachedProperties.cs # src/Markup/Avalonia.Markup.Xaml.Loader/xamlil.github # src/tools/Avalonia.Generators/Compiler/RoslynTypeSystem.cs
…in-XamlValueConverter
…in-XamlValueConverter
… and fix ColorPicker usage
…in-XamlValueConverter
maxkatz6
deleted the
fix-template-binding-and-allow-attributes-in-XamlValueConverter
branch
|
You can test this PR using the following package version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on kekekeks/XamlX#105
What does the pull request do?
How was the solution implemented (if it's not obvious)?
Instead of hardcoding compiler for TemplateBinding support, I decided to go with a custom attribute usable by the compiler.
Unfortunately, using this attribute is rather complicated, as XamlX as for now didn't have IPropertyInfo alternative, so I had to implement it first on our backends. Following changes to XamlValueConverter and updating all places where it's used. Because of that PR is rather big, so I wouldn't expect it to be merged soon.
Checklist
Fixed issues
Fixes #14576
Fixes #2357