Improved Windows icon rendering quality #14564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I extracted these changes from #12107. We have postponed dark mode support in our product, so there is no need for any controversial API changes. But we still want to see these icon rendering improvements in time for our final release. |
TomEdwardsEnscape
changed the title
|
You can test this PR using the following package version. |
maxkatz6
reviewed
Feb 11, 2024
maxkatz6
reviewed
Feb 11, 2024
maxkatz6
reviewed
Feb 11, 2024
|
In general, this PR looks good to me. Will test it on my machine on Monday. And will merge it if everything is good. |
maxkatz6
reviewed
Feb 14, 2024
Refresh icons when window DPI changes Provide ICON_SMALL icons Fixed Win32Icon.Size being incorrect when the exact size couldn't be found in the icon
TomEdwardsEnscape
force-pushed
the
fixes/win32-icon-message
branch
from
d208ee7 to
08ec390
Compare
|
You can test this PR using the following package version. |
TomEdwardsEnscape
added a commit
to Enscape/Avalonia
that referenced
this pull request
Mar 7, 2024
Refresh icons when window DPI changes Provide ICON_SMALL icons Fixed Win32Icon.Size being incorrect when the exact size couldn't be found in the icon
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On MS Windows, a window has three icons:
Big,Small, andSmall2.Small2is requested by other applications, and appears to have been added to support the Taskbar displaying the window's small icon with the platform theme variant.Previously, Avalonia only set the
Bigicon, and did not refresh that icon when the window's DPI changed. With this PR it provides values for all three icons and updates them when appropriate. This provides higher quality icon rendering:This PR also adds handling of the
WM_GETICONmessage. This message is sent by other applications when they request the local window's icon for their own use, and ought to have special handling because the message can request a DPI different from the window's own. This can happen when the window and taskbar are on different monitors with different DPIs, for example.Lastly, window icons are now set synchronously. Previously they were set with
PostMessage, which only enqueues the change. By usingSendMessageinstead, we avoid a race condition which caused the window sometimes to be briefly drawn without an icon.Breaking changes
None
Obsoletions / Deprecations
None
Fixed issues
Fixes #11569