Use embed JSON parser instead of Regex while parsing Deps file #14287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
the
backport-candidate-11.0.x
|
You can test this PR using the following package version. |
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Jan 21, 2024
|
You can test this PR using the following package version. |
maxkatz6
added a commit
that referenced
this pull request
Jan 24, 2024
* Use embed JSON parser instead of Regex while parsing Deps file * Make RuntimeXamlDiagnostic.Document settable at any time * Make JSONParser internal # Conflicts: # src/Markup/Avalonia.Markup.Xaml/RuntimeXamlLoaderConfiguration.cs
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Who would have guessed that Regex is bad for JSON parsing. Not me apparently.
Specifically, the problem was with nuget dependencies that have more than one dll library inside. Pretty rare situation, and nobody would notice, except Avalonia itself is such rare package with 10 libraries in one package.
Fixed issues
Fixes #14033
Fixes AvaloniaUI/AvaloniaVS#431