Prevent random dispatcher deadlocks #14229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can test this PR using the following package version. |
hamster620
added a commit
to carina-studio/AppSuiteBase
that referenced
this pull request
Jan 19, 2024
3 tasks
Please, provide a repro app, since it might be app-specific. |
|
@kekekeks 100% repro steps. On any platform (tested on windows + mac)
|
|
Hmmm, it seems that it's a leftover code from the time when foreground and background processing shared the same state flag. So now requesting background processing in that particular scenario effectively disables the foreground one. |
kekekeks
approved these changes
Feb 3, 2024
maxkatz6
added
the
backport-candidate-11.0.x
maxkatz6
pushed a commit
that referenced
this pull request
Feb 8, 2024
Co-authored-by: Lubomir Tetak <[email protected]>
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
|
@ltetak - Thank you so much for finding and fixing this issue! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
It happens from time to time that the rendering stops (tested on macOS but probably can happen on any platform). The culprit seems to be the Dispatcher does not keep properly the info if the impl has been signaled or not.
What is the current behavior?
_signaled property is true but the native implementation does nothing which breaks the loop
What is the updated/expected behavior with this PR?
don't break the loop
How was the solution implemented (if it's not obvious)?
I could not reproduce it 100% reliably but this seemed like the only place and it also makes no sense (to me) to reset the flag here since it was not signaled to the native impl.
Checklist