Implement ApiInformation checks #14090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxkatz6
added
os-windows
backport-candidate-11.0.x
maxkatz6
commented
Jan 3, 2024
| /// Any WinRT API might not be available even if Windows version is supposed to support them (Win PE, Xbox...). | ||
| /// Using ApiInformation is a typical solution in UWP/WinUI apps, so we should do as well. | ||
| /// </summary> | ||
| internal static unsafe class WinRTApiInformation |
There was a problem hiding this comment.
This API could also be used in our WinRT Compositor classes to check where it is supported. But compositor APIs are a bit more complicated, as they are available pretty early for UWP, but Win32 handles support was introduced pretty late.
|
You can test this PR using the following package version. |
kekekeks
approved these changes
Jan 3, 2024
maxkatz6
added
backported-11.0.x
and removed
backport-candidate-11.0.x
maxkatz6
added a commit
that referenced
this pull request
Jan 17, 2024
* Create wrapper for IApiInformationStatics * Use ApiInformation APIs to get if WinRT types are supported * Add some docs #Conflicts: # src/Windows/Avalonia.Win32/Input/WindowsInputPane.cs # src/Windows/Avalonia.Win32/WinRT/winrt.idl # src/Windows/Avalonia.Win32/WindowImpl.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Any WinRT API might not be available even if Windows version is supposed to support them (Win PE, Xbox...).
Using ApiInformation is a typical solution in UWP/WinUI apps, so we should do as well.
Fixed issues
Fixes #14058
Fixes #14040